Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply consistent import grouping with cargo fmt and update CI process #92

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jinjoolee07
Copy link
Contributor

@jinjoolee07 jinjoolee07 commented Jun 12, 2024

Fixes: #91

@jinjoolee07 jinjoolee07 linked an issue Jun 12, 2024 that may be closed by this pull request
@jinjoolee07 jinjoolee07 requested a review from sophie-cluml June 12, 2024 00:35
@sophie-cluml
Copy link
Contributor

@jinjoolee07 todo list 의 status 등을 세팅하고 나서 작업을 진행해주세요.

clippy error 를 먼저 해결하는 것이 필요해보입니다. #93 을 생성하였으니 그 이슈를 먼저 해결해 주세요.

@jinjoolee07 jinjoolee07 force-pushed the jinjoo/group-imports branch 3 times, most recently from ba36574 to 8243904 Compare June 13, 2024 05:07
Copy link
Contributor

@sophie-cluml sophie-cluml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophie-cluml
Copy link
Contributor

@jinjoolee07 rebase 부탁드립니다

@jinjoolee07 jinjoolee07 force-pushed the jinjoo/group-imports branch from 8243904 to dc3efa2 Compare June 17, 2024 23:44
@jinjoolee07 jinjoolee07 requested a review from sophie-cluml June 17, 2024 23:47
Copy link
Contributor

@sophie-cluml sophie-cluml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophie-cluml sophie-cluml merged commit 3fd77e0 into main Jun 17, 2024
8 checks passed
@sophie-cluml sophie-cluml deleted the jinjoo/group-imports branch June 17, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group imports by StdExternalCrate
2 participants